[all-commits] [llvm/llvm-project] abe467: [libcxx] [test] Fix the classic_table test on Windows

Martin Storsjö via All-commits all-commits at lists.llvm.org
Wed Mar 9 00:18:27 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: abe46776f33d11f9d6d7162d905d760aebafc590
      https://github.com/llvm/llvm-project/commit/abe46776f33d11f9d6d7162d905d760aebafc590
  Author: Martin Storsjö <martin at martin.st>
  Date:   2022-03-09 (Wed, 09 Mar 2022)

  Changed paths:
    M libcxx/test/std/localization/locale.categories/category.ctype/facet.ctype.special/facet.ctype.char.statics/classic_table.pass.cpp

  Log Message:
  -----------
  [libcxx] [test] Fix the classic_table test on Windows

On Windows, constants like F::alpha and F::print are bitmasks
consisting of multiple bits (e.g. F::alpha consisting of both the
bits F::upper and F::lower). In such a case, we can't check that
all the bits from all the expected constants are set. Instead,
check that (p[i] & mask) != 0 returns the expected value.

Differential Revision: https://reviews.llvm.org/D120802


  Commit: 9286a8238b948471a99834aaf4ea1316621f415f
      https://github.com/llvm/llvm-project/commit/9286a8238b948471a99834aaf4ea1316621f415f
  Author: Martin Storsjö <martin at martin.st>
  Date:   2022-03-09 (Wed, 09 Mar 2022)

  Changed paths:
    M libcxx/test/std/localization/locale.categories/category.monetary/locale.money.get/locale.money.get.members/get_long_double_ru_RU.pass.cpp
    M libcxx/test/std/localization/locale.categories/category.monetary/locale.money.put/locale.money.put.members/put_long_double_ru_RU.pass.cpp
    M libcxx/utils/libcxx/test/features.py

  Log Message:
  -----------
  [libcxx] [test] XFAIL the get/put long_double_ru_RU tests on Glibc < 2.27

Those older versions used a different monetary decimal separator.
To avoid unnecessary churn to support that, just XFAIL the test
on those older versions. (Up until
df1e43c496b43e998f66c610b0e15a0951f316b3, the whole test was XFAILed
on all versions of glibc.)

Differential Revision: https://reviews.llvm.org/D120979


Compare: https://github.com/llvm/llvm-project/compare/8a0fa4db39d8...9286a8238b94


More information about the All-commits mailing list