[all-commits] [llvm/llvm-project] 9832fd: [cmake] Use CMAKE_TRY_COMPILE_PLATFORM_VARIABLES

Shoaib Meenai via All-commits all-commits at lists.llvm.org
Tue Mar 8 15:25:49 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 9832fd589ef83d5305420ca66a655097dd594e42
      https://github.com/llvm/llvm-project/commit/9832fd589ef83d5305420ca66a655097dd594e42
  Author: Shoaib Meenai <smeenai at fb.com>
  Date:   2022-03-08 (Tue, 08 Mar 2022)

  Changed paths:
    M llvm/cmake/platforms/WinMsvc.cmake

  Log Message:
  -----------
  [cmake] Use CMAKE_TRY_COMPILE_PLATFORM_VARIABLES

Now that our minimum required CMake version is past 3.6, we can use
CMAKE_TRY_COMPILE_PLATFORM_VARIABLES instead of relying on environment
variable trickery. The two aren't entirely equivalent because
CMAKE_TRY_COMPILE_PLATFORM_VARIABLES is only used for try_compiles of
source files and not whole projects, but I ran LLVM configures before
and after this change and the generated CMakeCache.txt files were
identical, so this should be NFC for us.

Reviewed By: thakis

Differential Revision: https://reviews.llvm.org/D121035




More information about the All-commits mailing list