[all-commits] [llvm/llvm-project] 36f0df: [ORC][JITLink] Fix MachO absolute symbol handling, ...

lhames via All-commits all-commits at lists.llvm.org
Mon Mar 7 20:55:12 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 36f0dfd07a77fc801e3b54af66442778a4728868
      https://github.com/llvm/llvm-project/commit/36f0dfd07a77fc801e3b54af66442778a4728868
  Author: Lang Hames <lhames at gmail.com>
  Date:   2022-03-07 (Mon, 07 Mar 2022)

  Changed paths:
    M llvm/lib/ExecutionEngine/JITLink/MachOLinkGraphBuilder.cpp
    M llvm/lib/ExecutionEngine/Orc/ObjectLinkingLayer.cpp
    A llvm/test/ExecutionEngine/JITLink/X86/Inputs/MachO_global_absolute_def.s
    A llvm/test/ExecutionEngine/JITLink/X86/Inputs/MachO_local_absolute_def.s
    A llvm/test/ExecutionEngine/JITLink/X86/MachO_absolute_symbols.s

  Log Message:
  -----------
  [ORC][JITLink] Fix MachO absolute symbol handling, add test case.

This patch removes the unintended resolution of locally scoped absolute symbols
(which was causing unexpected definition errors).

It stops using the JITSymbolFlags::Absolute flag (it isn't set or used elsewhere,
and causes mismatch-flags asserts), and adds JITSymbolFlags::Exported to default
scoped absolute symbols.

Finally, we now set the scope of absolute symbols correctly in
MachOLinkGraphBuilder.




More information about the All-commits mailing list