[all-commits] [llvm/llvm-project] c41c57: Fix buildbots after https://reviews.llvm.org/D120755.

Greg Clayton via All-commits all-commits at lists.llvm.org
Mon Mar 7 11:47:20 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: c41c57468949036a06695f06a97a8e14e8b252bd
      https://github.com/llvm/llvm-project/commit/c41c57468949036a06695f06a97a8e14e8b252bd
  Author: Greg Clayton <gclayton at fb.com>
  Date:   2022-03-07 (Mon, 07 Mar 2022)

  Changed paths:
    M lldb/test/API/tools/lldb-vscode/attach/TestVSCode_attach.py

  Log Message:
  -----------
  Fix buildbots after https://reviews.llvm.org/D120755.

This improves this test a lot because before when using the "attachCommands" to run the following commands:

(lldb) target create -d /path/to/a.out
(lldb) process launch

This was racy as it wasn't stopping the program at the entry point, and the process might run to completion before we can even debug it. With the recent changes to the "attachCommands" we were waiting for the process to stop, but the process might be exited already, and that _should_ have caused the attach to fail since there was no process to attach to. By adding "--stop-at-entry" to the process launch, we ensure this should be less racy and give us a valid process to attach to.




More information about the All-commits mailing list