[all-commits] [llvm/llvm-project] 1bd336: [CoroElide] Remove fallback for frame layout deter...

Nikita Popov via All-commits all-commits at lists.llvm.org
Mon Mar 7 02:23:20 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 1bd33691cb1d10fb118ddf7f9fb305b112f67cbe
      https://github.com/llvm/llvm-project/commit/1bd33691cb1d10fb118ddf7f9fb305b112f67cbe
  Author: Nikita Popov <npopov at redhat.com>
  Date:   2022-03-07 (Mon, 07 Mar 2022)

  Changed paths:
    M llvm/lib/Transforms/Coroutines/CoroElide.cpp
    M llvm/test/Transforms/Coroutines/coro-elide-musttail.ll
    M llvm/test/Transforms/Coroutines/coro-elide-stat.ll
    M llvm/test/Transforms/Coroutines/coro-elide.ll
    M llvm/test/Transforms/Coroutines/coro-heap-elide.ll

  Log Message:
  -----------
  [CoroElide] Remove fallback for frame layout determination

Only determine the frame layout based on dereferenceable and align
attributes, and remove the type-based fallback, which is incompatible
with opaque pointers. The dereferenceable attribute is required,
while the align attribute uses default alignment of 1 (commonly,
align 1 attributes do not get placed, relying on default alignment).

The CoroSplit pass producing the resume function adds the necessary
attributes in https://github.com/llvm/llvm-project/blob/7daed359111f6d151fef447f520f85ef1dabedf6/llvm/lib/Transforms/Coroutines/CoroSplit.cpp#L840,
and their presence is checked in coro-debug.ll at least.

Differential Revision: https://reviews.llvm.org/D120988




More information about the All-commits mailing list