[all-commits] [llvm/llvm-project] 289f84: [mlir][sparse] Rename add{Pointer, Index} to append...

wren romano via All-commits all-commits at lists.llvm.org
Fri Mar 4 12:03:43 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 289f84a4a2cc0f97575bde7e39845c67a6e8c79d
      https://github.com/llvm/llvm-project/commit/289f84a4a2cc0f97575bde7e39845c67a6e8c79d
  Author: wren romano <2998727+wrengr at users.noreply.github.com>
  Date:   2022-03-04 (Fri, 04 Mar 2022)

  Changed paths:
    M mlir/lib/ExecutionEngine/SparseTensorUtils.cpp

  Log Message:
  -----------
  [mlir][sparse] Rename add{Pointer,Index} to append{Pointer,Index}

This clarifies that these methods only work in append mode, not for general insertions.  This is a prospective change towards https://github.com/llvm/llvm-project/issues/51652 which also performs random-access insertions, so we want to avoid confusion.

Reviewed By: aartbik

Differential Revision: https://reviews.llvm.org/D120929




More information about the All-commits mailing list