[all-commits] [llvm/llvm-project] 984197: [lld-macho][nfc] Rename some tests for consistency

Jez Ng via All-commits all-commits at lists.llvm.org
Fri Mar 4 11:23:38 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 984197612ce9dcef9c48edccc7dd9b861077f1ae
      https://github.com/llvm/llvm-project/commit/984197612ce9dcef9c48edccc7dd9b861077f1ae
  Author: Jez Ng <jezng at fb.com>
  Date:   2022-03-04 (Fri, 04 Mar 2022)

  Changed paths:
    A lld/test/MachO/archive-symbol-resolution.s
    R lld/test/MachO/resolution.s
    R lld/test/MachO/symbol-order.s
    A lld/test/MachO/symbol-resolution.s

  Log Message:
  -----------
  [lld-macho][nfc] Rename some tests for consistency

Now all the tests that cover symbol resolution / precedence have
"resolution" in their filename.

I also added a couple of extra comments.

Reviewed By: #lld-macho, thakis

Differential Revision: https://reviews.llvm.org/D120938


  Commit: 72c5b26f3d6502fc64ae78923c92ef57f7e971c4
      https://github.com/llvm/llvm-project/commit/72c5b26f3d6502fc64ae78923c92ef57f7e971c4
  Author: Jez Ng <jezng at fb.com>
  Date:   2022-03-04 (Fri, 04 Mar 2022)

  Changed paths:
    M lld/test/MachO/map-file.s

  Log Message:
  -----------
  [lld-macho][nfc] Use %X in mapfile test

LLD (and ld64) emits uppercase hex addresses in the mapfile. The
map-file.s test passes right now because the addresses we emit happen
not to include any alphabets, but that can easily change.

I noticed this while dealing with
https://github.com/llvm/llvm-project/issues/54184.

Reviewed By: #lld-macho, thakis

Differential Revision: https://reviews.llvm.org/D120941


Compare: https://github.com/llvm/llvm-project/compare/317e6a80778c...72c5b26f3d65


More information about the All-commits mailing list