[all-commits] [llvm/llvm-project] 0c1d33: [hmaptool] Fix dumping

Shoaib Meenai via All-commits all-commits at lists.llvm.org
Thu Mar 3 15:19:05 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 0c1d330431f59011fd861e291d5048858a973c5a
      https://github.com/llvm/llvm-project/commit/0c1d330431f59011fd861e291d5048858a973c5a
  Author: Shoaib Meenai <smeenai at fb.com>
  Date:   2022-03-03 (Thu, 03 Mar 2022)

  Changed paths:
    M clang/utils/hmaptool/hmaptool

  Log Message:
  -----------
  [hmaptool] Fix dumping

It was complaining about too many values to unpack, since our struct
unpack format string specified six members, but we only had five
variables to unpack to. The sixth value is the max value length, but
it's not used in dumping, so we can ignore it.

Reviewed By: bruno

Differential Revision: https://reviews.llvm.org/D118004


  Commit: b4c1cbff79d0631c35ca2efa97bd2a47929945b8
      https://github.com/llvm/llvm-project/commit/b4c1cbff79d0631c35ca2efa97bd2a47929945b8
  Author: Shoaib Meenai <smeenai at fb.com>
  Date:   2022-03-03 (Thu, 03 Mar 2022)

  Changed paths:
    M clang/utils/hmaptool/hmaptool

  Log Message:
  -----------
  [hmaptool] Fix string decoding for Python 3

Our "strings" were actually bytes, which made verbose dumping fail.
Decode them so they actually become strings.

Reviewed By: bruno

Differential Revision: https://reviews.llvm.org/D118005


Compare: https://github.com/llvm/llvm-project/compare/bc1574b4951f...b4c1cbff79d0


More information about the All-commits mailing list