[all-commits] [llvm/llvm-project] 2555ed: [InstCombine] Add callee bitcast test with byval o...

Nikita Popov via All-commits all-commits at lists.llvm.org
Thu Mar 3 01:55:30 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 2555ed55a434b731c03f9b6286e93f4637e7d58d
      https://github.com/llvm/llvm-project/commit/2555ed55a434b731c03f9b6286e93f4637e7d58d
  Author: Nikita Popov <npopov at redhat.com>
  Date:   2022-03-03 (Thu, 03 Mar 2022)

  Changed paths:
    M llvm/test/Transforms/InstCombine/byval.ll

  Log Message:
  -----------
  [InstCombine] Add callee bitcast test with byval on callee (NFC)

Same as the existing test, but the callee also has a byval
attribute.


  Commit: 6c8adc505471542be38bd71d1000062daa46d7bc
      https://github.com/llvm/llvm-project/commit/6c8adc505471542be38bd71d1000062daa46d7bc
  Author: Nikita Popov <npopov at redhat.com>
  Date:   2022-03-03 (Thu, 03 Mar 2022)

  Changed paths:
    M llvm/lib/Transforms/InstCombine/InstCombineCalls.cpp
    M llvm/test/Transforms/InstCombine/byval.ll

  Log Message:
  -----------
  [InstCombine] Remove unnecessary byval check in callee cast fold

The logic for handling this was fixed in
8d7f118ab2b9e51d6cf2811291e319b4d977eb8c, but the check for byval
on the callee was retained. This resulted in a weird situation
where the transform would work depending on whether the byval
was only on the call or on both the call and the function.


Compare: https://github.com/llvm/llvm-project/compare/e4fa8291a277...6c8adc505471


More information about the All-commits mailing list