[all-commits] [llvm/llvm-project] badb6e: [lldb/crashlog] Fix scripted_crashlog_json.test fa...

Med Ismail Bennani via All-commits all-commits at lists.llvm.org
Fri Feb 25 17:21:11 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: badb6e2730a970b5ee94f0adb77c2de741ebbf68
      https://github.com/llvm/llvm-project/commit/badb6e2730a970b5ee94f0adb77c2de741ebbf68
  Author: Med Ismail Bennani <medismail.bennani at gmail.com>
  Date:   2022-02-25 (Fri, 25 Feb 2022)

  Changed paths:
    M lldb/examples/python/crashlog.py
    M lldb/test/Shell/ScriptInterpreter/Python/Crashlog/Inputs/a.out.ips
    M lldb/test/Shell/ScriptInterpreter/Python/Crashlog/Inputs/scripted_crashlog.ips

  Log Message:
  -----------
  [lldb/crashlog] Fix scripted_crashlog_json.test failure

This patch should fix the test failure on scripted_crashlog_json.test.

The failure is happening because crash reporter will obfuscate the
executable path in the crashlog, if it is located inside the user's
home directory and replace it with `/USER/*/` as a placeholder.

To fix that, we can patch the placeholder with the executable path
before loading the crashlog in lldb.

This also fixes a bug where we would create another target when loading
the crashlog in a scripted process, even if lldb already had a target
for it. Now, crashlog will only create a target if there is none in lldb.

Differential Revision: https://reviews.llvm.org/D120598

Signed-off-by: Med Ismail Bennani <medismail.bennani at gmail.com>


  Commit: 425880ed35ee399d8f1af0aac60100e4901f289f
      https://github.com/llvm/llvm-project/commit/425880ed35ee399d8f1af0aac60100e4901f289f
  Author: Med Ismail Bennani <medismail.bennani at gmail.com>
  Date:   2022-02-25 (Fri, 25 Feb 2022)

  Changed paths:
    M lldb/bindings/interface/SBDebugger.i
    M lldb/source/API/SBDebugger.cpp
    M lldb/test/API/functionalities/progress_reporting/TestProgressReporting.py

  Log Message:
  -----------
  Reland "[lldb/test] Fix TestProgressReporting.py race issue with the event listener"

This patch relands commit 3e3e79a9e4c378b59f5f393f556e6a84edcd8898, and
fixes the memory sanitizer issue described in D120284, by removing the
output arguments from the LLDB_INSTRUMENT_VA invocation.

Differential Revision: https://reviews.llvm.org/D120599

Signed-off-by: Med Ismail Bennani <medismail.bennani at gmail.com>


Compare: https://github.com/llvm/llvm-project/compare/cb1654ee4bee...425880ed35ee


More information about the All-commits mailing list