[all-commits] [llvm/llvm-project] cb1654: [Driver][test] Clean up some AIX tests

[Fangrui Song via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: cb1654ee4beedc875c25a95e7b98f1aaed0b9e35
      https://github.com/llvm/llvm-project/commit/cb1654ee4beedc875c25a95e7b98f1aaed0b9e35
  Author: Fangrui Song <i at maskray.me>
  Date:   2022-02-26 (Sat, 26 Feb 2022)

  Changed paths:
    M clang/test/Driver/aix-as.c
    M clang/test/Driver/aix-data-sections.c
    M clang/test/Driver/aix-err-options.c
    M clang/test/Driver/aix-ld.c
    M clang/test/Driver/aix-mcpu-default.c
    M clang/test/Driver/aix-object-mode.c
    M clang/test/Driver/aix-rtlib.c
    M clang/test/Driver/aix-toolchain-include.cpp

  Log Message:
  -----------
  [Driver][test] Clean up some AIX tests

* For `-###`, `-o %t.o` is unnecessary if we don't specifically test the
  output filename.
* --target= is the canonical spelling. -target is a legacy spelling which
  unfortunately cannot be removed because there are too many uses.
* -no-canonical-prefixes uses the dereferenced absolute path for the cc1
  command. For most tests "-cc1" is sufficient to identify the command line, no
  need to specifically test the "clang" command, and -no-canonical-prefixes can
  removed.
* --unwindlib= is the preferred spelling. -u is a short option taking a value,
  which means a -uwindlib= typo cannot be detected.

I recommend that you take a look at linux-cross.cpp. Testing include paths and
library paths in one RUN line is sometimes more readable than having separate
include/library tests.

Having separate RUN lines for misc features like -fdata-sections
(`aix-data-sections.c`) is wasteful. It may be better testing multiple
options in a single RUN command.

Reviewed By: jsji

Differential Revision: https://reviews.llvm.org/D119309