[all-commits] [llvm/llvm-project] d955ca: [BufferDeallocation] Don't assume successor operan...

[Benjamin Kramer via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: d955ca49379e73485304eb7f500db53e33109b0f
      https://github.com/llvm/llvm-project/commit/d955ca49379e73485304eb7f500db53e33109b0f
  Author: Benjamin Kramer <benny.kra at googlemail.com>
  Date:   2022-02-17 (Thu, 17 Feb 2022)

  Changed paths:
    M mlir/lib/Dialect/Bufferization/Transforms/BufferDeallocation.cpp
    M mlir/test/Dialect/Bufferization/Transforms/buffer-deallocation.mlir

  Log Message:
  -----------
  [BufferDeallocation] Don't assume successor operands are unique

This would create a double free when a memref is passed twice to the
same op. This wasn't a problem at the time the pass was written but is
common since the introduction of scf.while.

There's a latent non-determinism that's triggered by the test, but this
change is messy enough as-is so I'll leave that for later.

Differential Revision: https://reviews.llvm.org/D120044