[all-commits] [llvm/llvm-project] dd88f4: [AArch64] Make getInstSizeInBytes() use instructio...

tyb0807 via All-commits all-commits at lists.llvm.org
Tue Feb 1 02:39:55 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: dd88f40c80f54e5f66b5ead1787f88c376b61d8a
      https://github.com/llvm/llvm-project/commit/dd88f40c80f54e5f66b5ead1787f88c376b61d8a
  Author: tyb0807 <sontuan.vu at arm.com>
  Date:   2022-02-01 (Tue, 01 Feb 2022)

  Changed paths:
    M llvm/lib/Target/AArch64/AArch64InstrInfo.cpp
    M llvm/lib/Target/AArch64/AArch64InstrInfo.td
    M llvm/unittests/Target/AArch64/InstSizes.cpp

  Log Message:
  -----------
  [AArch64] Make getInstSizeInBytes() use instruction size from InstrInfo.td

Currently, AArch64InstrInfo::getInstSizeInBytes() uses hard-coded
instruction size for some pseudo-instructions, while this
information should ideally be found in AArch64InstrInfo.td file (which
can be accessed via MCInstrDesc). Hence, the .td file should be updated
and no hard-coded instruction sizes should be used by
getInstSizeInBytes() anymore.

Differential Revision: https://reviews.llvm.org/D117970


  Commit: 762f0b5463286c6cbe585e44e2830ee0e5b6c40b
      https://github.com/llvm/llvm-project/commit/762f0b5463286c6cbe585e44e2830ee0e5b6c40b
  Author: tyb0807 <sontuan.vu at arm.com>
  Date:   2022-02-01 (Tue, 01 Feb 2022)

  Changed paths:
    M llvm/lib/Target/ARM/ARMBaseInstrInfo.cpp
    M llvm/lib/Target/ARM/ARMInstrInfo.td
    M llvm/lib/Target/ARM/ARMInstrThumb.td
    M llvm/lib/Target/ARM/ARMInstrThumb2.td
    M llvm/unittests/Target/ARM/CMakeLists.txt
    A llvm/unittests/Target/ARM/InstSizes.cpp
    M llvm/utils/gn/secondary/llvm/unittests/Target/ARM/BUILD.gn

  Log Message:
  -----------
  [ARM] Make getInstSizeInBytes() use instruction size from InstrInfo.td

Currently, ARMBaseInstrInfo::getInstSizeInBytes() uses hard-coded
instruction size for some pseudo-instructions, while this
information should ideally be found in ARMInstrInfo.td,
ARMInstrThumb(2).td files (which can be accessed via MCInstrDesc). Hence,
the .td files should be updated and no hard-coded instruction sizes
should be used by getInstSizeInBytes() anymore.

Differential Revision: https://reviews.llvm.org/D118009


Compare: https://github.com/llvm/llvm-project/compare/b00bce2a93b3...762f0b546328


More information about the All-commits mailing list