[all-commits] [llvm/llvm-project] 52c7fa: [demangler] improve test harness

Nathan Sidwell via All-commits all-commits at lists.llvm.org
Wed Jan 26 04:59:57 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 52c7faeae8fce49cd7e3853a29bb38e3ce5be892
      https://github.com/llvm/llvm-project/commit/52c7faeae8fce49cd7e3853a29bb38e3ce5be892
  Author: Nathan Sidwell <nathan at acm.org>
  Date:   2022-01-26 (Wed, 26 Jan 2022)

  Changed paths:
    M libcxxabi/test/test_demangle.pass.cpp

  Log Message:
  -----------
  [demangler] improve test harness

The demangler test harness is a little unclear.  The failed demangling
message always causes me to think about 'reality', changing to a
simple 'Found' seems clearer.

The expected-to-fail tests abort as soon as one passes, rather than
continue, and then abort if any passed.  This changes that loop to
fail at the end, in a similar manner to the expected-to-work loop.

Reviewed By: ChuanqiXu

Differential Revision: https://reviews.llvm.org/D118130


  Commit: 4e5fce58485cc69ee69da10e26a338ceeef280a0
      https://github.com/llvm/llvm-project/commit/4e5fce58485cc69ee69da10e26a338ceeef280a0
  Author: Nathan Sidwell <nathan at acm.org>
  Date:   2022-01-26 (Wed, 26 Jan 2022)

  Changed paths:
    M libcxxabi/src/demangle/ItaniumDemangle.h
    M llvm/include/llvm/Demangle/ItaniumDemangle.h

  Log Message:
  -----------
  [demangler] refactor SpecialSubKind

Code generating the special substitutions in std is a switch statement
with each case block containing the same conststruction template.  It
is more efficient to commonize that after the switch, having
determined which SubKind to create.  Also, let's sort the cases.

Reviewed By: ChuanqiXu

Differential Revision: https://reviews.llvm.org/D118131


Compare: https://github.com/llvm/llvm-project/compare/b58174d62488...4e5fce58485c


More information about the All-commits mailing list