[all-commits] [llvm/llvm-project] b58174: Cleanup headers for BinaryFormat

[serge-sans-paille via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: b58174d6248805c8994cfe685c826d3f14961202
      https://github.com/llvm/llvm-project/commit/b58174d6248805c8994cfe685c826d3f14961202
  Author: serge-sans-paille <sguelton at redhat.com>
  Date:   2022-01-26 (Wed, 26 Jan 2022)

  Changed paths:
    M llvm/include/llvm/BinaryFormat/AMDGPUMetadataVerifier.h
    M llvm/include/llvm/BinaryFormat/Dwarf.h
    M llvm/include/llvm/BinaryFormat/ELF.h
    M llvm/include/llvm/BinaryFormat/MsgPackReader.h
    M llvm/include/llvm/BinaryFormat/MsgPackWriter.h
    M llvm/lib/BinaryFormat/AMDGPUMetadataVerifier.cpp
    M llvm/lib/BinaryFormat/ELF.cpp
    M llvm/lib/BinaryFormat/Magic.cpp
    M llvm/tools/llvm-readobj/ELFDumper.cpp

  Log Message:
  -----------
  Cleanup headers for BinaryFormat

A few header removal, some forward declarations. As usual, this can
break your build due to false dependencies, the most notable change are:

- "llvm/BinaryFormat/AMDGPUMetadataVerifier.h" no longer includes "llvm/BinaryFormat/MsgPackDocument.h"

The impact on generated preprocessed lines for LLVMBinaryFormat is
pretty nice:

$ clang++ -E  -Iinclude -I../llvm/include ../llvm/lib/BinaryFormat/*.cpp -std=c++14 -fno-rtti -fno-exceptions | wc -l
before this patch: 705281
after this patch: 751456

Discourse thread on the topic: https://llvm.discourse.group/t/include-what-you-use-include-cleanup