[all-commits] [llvm/llvm-project] 7d1956: [lldb] Ignore non-address bits in "memory find" ar...

David Spickett via All-commits all-commits at lists.llvm.org
Mon Jan 24 02:43:05 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 7d19566c3bfb3efacb629d18839e2d85761156ab
      https://github.com/llvm/llvm-project/commit/7d19566c3bfb3efacb629d18839e2d85761156ab
  Author: David Spickett <david.spickett at linaro.org>
  Date:   2022-01-24 (Mon, 24 Jan 2022)

  Changed paths:
    M lldb/source/Commands/CommandObjectMemory.cpp
    A lldb/test/API/linux/aarch64/tagged_memory_access/Makefile
    A lldb/test/API/linux/aarch64/tagged_memory_access/TestAArch64LinuxTaggedMemoryAccess.py
    A lldb/test/API/linux/aarch64/tagged_memory_access/main.c
    R lldb/test/API/linux/aarch64/tagged_memory_read/Makefile
    R lldb/test/API/linux/aarch64/tagged_memory_read/TestAArch64LinuxTaggedMemoryRead.py
    R lldb/test/API/linux/aarch64/tagged_memory_read/main.c

  Log Message:
  -----------
  [lldb] Ignore non-address bits in "memory find" arguments

This removes the non-address bits before we try to use
the addresses.

Meaning that when results are shown, those results won't
show non-address bits either. This follows what "memory read"
has done. On the grounds that non-address bits are a property
of a pointer, not the memory pointed to.

I've added testing and merged the find and read tests into one
file.

Note that there are no API side changes because "memory find"
does not have an equivalent API call.

Reviewed By: omjavaid

Differential Revision: https://reviews.llvm.org/D117299




More information about the All-commits mailing list