[all-commits] [llvm/llvm-project] 7c471b: [mlir][pdl] OperationOp should not be side-effect ...

[Jeff Niu via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 7c471b56f2c22b984847100b318b01e31bf5f9cb
      https://github.com/llvm/llvm-project/commit/7c471b56f2c22b984847100b318b01e31bf5f9cb
  Author: Mogball <jeffniu22 at gmail.com>
  Date:   2022-01-20 (Thu, 20 Jan 2022)

  Changed paths:
    M mlir/include/mlir/Dialect/PDL/IR/PDLOps.td
    M mlir/test/Conversion/PDLToPDLInterp/pdl-to-pdl-interp-rewriter.mlir
    A mlir/test/Dialect/PDL/canonicalize.mlir

  Log Message:
  -----------
  [mlir][pdl] OperationOp should not be side-effect free

Unbound OperationOp in the matcher (i.e. one with no uses) is already disallowed by the verifier. However, an OperationOp in the rewriter is not side-effect free -- it's creating an op!

Reviewed By: rriddle

Differential Revision: https://reviews.llvm.org/D117825