[all-commits] [llvm/llvm-project] d0cace: [mlir][pdl] Some ops are missing `NoSideEffect`

Jeff Niu via All-commits all-commits at lists.llvm.org
Thu Jan 20 12:21:14 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: d0cace5087145b6bd8c833cc25d3e6d08442326c
      https://github.com/llvm/llvm-project/commit/d0cace5087145b6bd8c833cc25d3e6d08442326c
  Author: Mogball <jeffniu22 at gmail.com>
  Date:   2022-01-20 (Thu, 20 Jan 2022)

  Changed paths:
    M mlir/include/mlir/Dialect/PDL/IR/PDLOps.td

  Log Message:
  -----------
  [mlir][pdl] Some ops are missing `NoSideEffect`

Querying or building constraints on types, operands, results, and attributes are side-effect free in both the matcher and rewriter. The ops should be marked as such.

Reviewed By: rriddle

Differential Revision: https://reviews.llvm.org/D117826




More information about the All-commits mailing list