[all-commits] [llvm/llvm-project] 22430e: [CodeGen] Rename emitCalleeSavedFrameMoves

Alexander Shaposhnikov via All-commits all-commits at lists.llvm.org
Sun Jan 9 17:33:24 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 22430ede7e497d67c87fe900cc685690c5c3ec0c
      https://github.com/llvm/llvm-project/commit/22430ede7e497d67c87fe900cc685690c5c3ec0c
  Author: Alexander Shaposhnikov <ashaposhnikov at google.com>
  Date:   2022-01-10 (Mon, 10 Jan 2022)

  Changed paths:
    M llvm/include/llvm/CodeGen/TargetFrameLowering.h
    M llvm/lib/CodeGen/CFIInstrInserter.cpp
    M llvm/lib/Target/AArch64/AArch64FrameLowering.h
    M llvm/lib/Target/X86/X86FrameLowering.cpp
    M llvm/lib/Target/X86/X86FrameLowering.h

  Log Message:
  -----------
  [CodeGen] Rename emitCalleeSavedFrameMoves

This diff renames emitCalleeSavedFrameMoves to avoid conflicts with
non-virtual methods of derived classes having the same name but different semantics.
E.g. the class AArch64FrameLowering used to have (non-virtual) "emitCalleeSavedFrameMoves"
but it started to override TargetFrameLowering::emitCalleeSavedFrameMoves after
https://github.com/llvm/llvm-project/commit/c3e6555616 though its usage and semantics didn't change.
P.S. for x86 there was no conflict because the signature of
non-virtual X86FrameLowering::emitCalleeSavedFrameMoves is different

Test plan: make check-all

Differential revision: https://reviews.llvm.org/D114140




More information about the All-commits mailing list