[all-commits] [llvm/llvm-project] 24c68e: Reland "[X86][MS-InlineAsm] Use exact conditions t...

Phoebe Wang via All-commits all-commits at lists.llvm.org
Fri Dec 24 01:43:07 PST 2021

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 24c68ea1eb4fc0d0e782424ddb02da9e8c53ddf5
  Author: Phoebe Wang <phoebe.wang at intel.com>
  Date:   2021-12-24 (Fri, 24 Dec 2021)

  Changed paths:
    M clang/test/CodeGen/ms-inline-asm-functions.c
    M llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp
    M llvm/lib/Target/X86/AsmParser/X86Operand.h

  Log Message:
  Reland "[X86][MS-InlineAsm] Use exact conditions to recognize MS global variables"

This reverts commit a954558e878ed9e97e99036229e99af8c6b6c881.

Thanks Yuanfang's help. I think I found the root cause of the buildbot

The failed test has both Memory and Immediate X86Operand. All data of
different operand kinds share the same memory space by a union
definition. So it has chance we get the wrong result if we don't check
the operand kind.

It's probably it happen to be the correct value in my local environment
so that I can't reproduce the fail.

Differential Revision: https://reviews.llvm.org/D116090

More information about the All-commits mailing list