[all-commits] [llvm/llvm-project] 833393: [asm] Correctly handle special names in variants

Nico Weber via All-commits all-commits at lists.llvm.org
Mon Nov 15 12:37:39 PST 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 833393e021dc1b3844ac6982455a32c2e55f748e
      https://github.com/llvm/llvm-project/commit/833393e021dc1b3844ac6982455a32c2e55f748e
  Author: Nico Weber <thakis at chromium.org>
  Date:   2021-11-15 (Mon, 15 Nov 2021)

  Changed paths:
    M llvm/lib/CodeGen/AsmPrinter/AsmPrinterInlineAsm.cpp
    M llvm/test/CodeGen/Generic/inline-asm-special-strings.ll

  Log Message:
  -----------
  [asm] Correctly handle special names in variants

There's really no reason why anyone should use these special names in a variant.
I noticed this while reading the code: all other writes to OS are guarded by
this conditional, and the behavior with the check seems more correct, so
let's add the check.

Differential Revision: https://reviews.llvm.org/D113909




More information about the All-commits mailing list