[all-commits] [llvm/llvm-project] a271f2: [lld-macho][nfc] Canonicalize all pointers to Inpu...

[Jez Ng via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: a271f2410f6c6ec367a12b74aef426239b96f70b
      https://github.com/llvm/llvm-project/commit/a271f2410f6c6ec367a12b74aef426239b96f70b
  Author: Jez Ng <jezng at fb.com>
  Date:   2021-10-29 (Fri, 29 Oct 2021)

  Changed paths:
    M lld/MachO/InputSection.h
    M lld/MachO/Symbols.cpp
    M lld/MachO/Symbols.h
    M lld/MachO/SyntheticSections.cpp
    M lld/MachO/Writer.cpp

  Log Message:
  -----------
  [lld-macho][nfc] Canonicalize all pointers to InputSections early on

Having to remember to call `canonical()` all over the place is
error-prone; let's do it in a centralized location instead. It also
appears to improve performance slightly.

             base           diff           difference (95% CI)
  sys_time   0.984 ± 0.009  0.983 ± 0.014  [  -0.8% ..   +0.6%]
  user_time  6.508 ± 0.035  6.475 ± 0.036  [  -0.8% ..   -0.2%]
  wall_time  5.321 ± 0.034  5.300 ± 0.033  [  -0.7% ..   -0.1%]
  samples    36             23

Reviewed By: #lld-macho, thakis

Differential Revision: https://reviews.llvm.org/D112687


  Commit: 6c2f26a159ec0a68d16424cc8aadd8801c7ef31d
      https://github.com/llvm/llvm-project/commit/6c2f26a159ec0a68d16424cc8aadd8801c7ef31d
  Author: Jez Ng <jezng at fb.com>
  Date:   2021-10-29 (Fri, 29 Oct 2021)

  Changed paths:
    M lld/MachO/Config.h
    M lld/MachO/Driver.cpp
    M lld/test/MachO/lc-linker-option.ll

  Log Message:
  -----------
  [lld-macho] -all_load and -ObjC should not affect LC_LINKER_OPTION flags

In particular, they should not cause archives to be eagerly loaded. This
matches ld64's behavior.

Fixes PR52246.

Reviewed By: #lld-macho, thakis

Differential Revision: https://reviews.llvm.org/D112756


Compare: https://github.com/llvm/llvm-project/compare/86972f111497...6c2f26a159ec