[all-commits] [llvm/llvm-project] b43258: [NFC][X86] Add MC tests for all untested VIA PadLo...

Jessica Clarke via All-commits all-commits at lists.llvm.org
Fri Oct 22 17:57:57 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: b432583d28ee99313fa834139be9535639957d76
      https://github.com/llvm/llvm-project/commit/b432583d28ee99313fa834139be9535639957d76
  Author: Jessica Clarke <jrtc27 at jrtc27.com>
  Date:   2021-10-23 (Sat, 23 Oct 2021)

  Changed paths:
    M llvm/test/MC/X86/padlock.s

  Log Message:
  -----------
  [NFC][X86] Add MC tests for all untested VIA PadLock instructions

We currently only test the encoding of xstore but none of the other
instructions, which should all have their implicit REP prefix be
verified as working.

Reviewed By: craig.topper

Differential Revision: https://reviews.llvm.org/D112354


  Commit: 2d8c18fbbdd1b07ab0d36ac49ef63f4d243afb8b
      https://github.com/llvm/llvm-project/commit/2d8c18fbbdd1b07ab0d36ac49ef63f4d243afb8b
  Author: Jessica Clarke <jrtc27 at jrtc27.com>
  Date:   2021-10-23 (Sat, 23 Oct 2021)

  Changed paths:
    M llvm/lib/Target/X86/X86InstrSystem.td
    M llvm/test/MC/X86/padlock.s

  Log Message:
  -----------
  [X86] Don't add implicit REP prefix to VIA PadLock xstore

Commit 8fa3e8fa1492 added an implicit REP prefix to all VIA PadLock
instructions, but GNU as doesn't add one to xstore, only all the others.
This resulted in a kernel panic regression in FreeBSD upon updating to
LLVM 11 (https://bugs.freebsd.org/259218) which includes the commit in
question. This partially reverts that commit.

Reviewed By: craig.topper

Differential Revision: https://reviews.llvm.org/D112355


Compare: https://github.com/llvm/llvm-project/compare/fc3f92a8f457...2d8c18fbbdd1


More information about the All-commits mailing list