[all-commits] [llvm/llvm-project] fc3f92: [flang] Fix buildbot (new warnings on old code)

Peter Klausler via All-commits all-commits at lists.llvm.org
Fri Oct 22 17:52:47 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: fc3f92a8f457d3067aeb7043e876cfa437c24e31
      https://github.com/llvm/llvm-project/commit/fc3f92a8f457d3067aeb7043e876cfa437c24e31
  Author: peter klausler <pklausler at nvidia.com>
  Date:   2021-10-22 (Fri, 22 Oct 2021)

  Changed paths:
    M flang/lib/Evaluate/tools.cpp
    M flang/lib/Semantics/check-declarations.cpp

  Log Message:
  -----------
  [flang] Fix buildbot (new warnings on old code)

The clang-aarch64-full-2stage buildbot is complaining about a
warning with three instances in f18 code (none modified recently).
The warning is for using the | bitwise OR operator on bool operands.

In one instance, the bitwise operator was being used instead of the
logical || operator in order to avoid short-circuting.  The fix
requires using some temporary variables.  In the other two instances,
the bitwise operator seemed more idiomatic in context, but can be
replaced without harm with the logical operator.

Pushing without review as confidence is high and nobody wants
a buildbot to stay sad for long.




More information about the All-commits mailing list