[all-commits] [llvm/llvm-project] 27969c: tsan: refactor trace tests

[Dmitry Vyukov via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 27969c4e00bb3fcfc8cc149864e1b1f7e87a6753
      https://github.com/llvm/llvm-project/commit/27969c4e00bb3fcfc8cc149864e1b1f7e87a6753
  Author: Dmitry Vyukov <dvyukov at google.com>
  Date:   2021-10-17 (Sun, 17 Oct 2021)

  Changed paths:
    M compiler-rt/lib/tsan/tests/unit/tsan_trace_test.cpp

  Log Message:
  -----------
  tsan: refactor trace tests

Instead of creating real threads for trace tests
create a new ThreadState in the main thread.
This makes the tests more unit-testy and will also
help with future trace tests that will need
more than 1 thread. Creating more than 1 real thread and
dispatching test actions across multiple threads in the
required deterministic order is painful.

This is resubmit of reverted D110546 with 2 changes:
1. The previous version patched ImitateTlsWrite to not
expect ThreadState to be allocated in TLS (the CHECK
failed for the fake test threads).
This added an ugly hack into production code and was still
logically wrong because we imitated write to the main
thread TLS/stack when we started the fake test thread
(which has nothing to do with the main thread TLS/stack).
This version uses ThreadType::Fiber instead of ThreadType::Regular
for the fake threads. This naturally makes ThreadStart skip
obtaining stack/tls and imitating writes to them.

2. This version still skips the tests on Darwin and PowerPC
to be on the safer side. Build bots reported failures for PowerPC
for the previous version.

Reviewed By: melver

Differential Revision: https://reviews.llvm.org/D111156