[all-commits] [llvm/llvm-project] a92cf5: [clang-format] [PR42014, PR52021] don't let clang-f...

MyDeveloperDay via All-commits all-commits at lists.llvm.org
Fri Oct 15 01:47:57 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: a92cf5a5a0cd01145f8db2ae09334a8b43a1271b
      https://github.com/llvm/llvm-project/commit/a92cf5a5a0cd01145f8db2ae09334a8b43a1271b
  Author: mydeveloperday <mydeveloperday at gmail.com>
  Date:   2021-10-15 (Fri, 15 Oct 2021)

  Changed paths:
    M clang/tools/clang-format/ClangFormat.cpp

  Log Message:
  -----------
  [clang-format] [PR42014,PR52021] don't let clang-format assert/crash when file being formatted is read-only/locked

This is a bug which gets reported from time to time and we've had multiple attempts to fix it, but don't want to fix it by adding frontEnd to the mix.

This patch aim to find a trivial, but not that sophisticated way of emitting the error without the additional impact of adding libFrontEnd to clang-format.
See {D90121} for analysis of why we don't want those previous attempts

Reviewed By: HazardyKnusperkeks

Differential Revision: https://reviews.llvm.org/D111815




More information about the All-commits mailing list