[all-commits] [llvm/llvm-project] 35d710: Use Module's FileSpec for limiting binaries to set...

[Jason Molenda via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 35d710148b98e2ec52056271e7f9103620593b7a
      https://github.com/llvm/llvm-project/commit/35d710148b98e2ec52056271e7f9103620593b7a
  Author: Jason Molenda <jason at molenda.com>
  Date:   2021-10-14 (Thu, 14 Oct 2021)

  Changed paths:
    M lldb/source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderMacOS.cpp

  Log Message:
  -----------
  Use Module's FileSpec for limiting binaries to set dyld breakpoint in

When DynamicLoaderMacOS::SetNotificationBreakpoint sets the breakpoint
for new binaries being loaded/unloaded, it limits the scope of that
breakpoint to just dyld, so we don't re-evaluate the breakpoint for
every new binary loaded.  I wrote this to get the module's ObjectFile
FileSpec in an earlier change, but this is not correct.  If lldb
is debugging a remote system, and it had to read dyld out of memory
from the remote system, it will have no FileSpec on the lldb debugger
host.  We need to grab the Module's FileSpec, which in this case is
actually falling back to the PlatformFileSpec, the binary path on the
target system.

rdar://84199646