[all-commits] [llvm/llvm-project] 8c66d7: [test] Fix asan dynamic unit tests with per-target...

Collin Baker via All-commits all-commits at lists.llvm.org
Thu Oct 14 13:48:22 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 8c66d781721fd8779b7b57b675913789051aa946
      https://github.com/llvm/llvm-project/commit/8c66d781721fd8779b7b57b675913789051aa946
  Author: Collin Baker <collinbaker at chromium.org>
  Date:   2021-10-14 (Thu, 14 Oct 2021)

  Changed paths:
    M compiler-rt/lib/asan/tests/CMakeLists.txt
    M compiler-rt/test/asan/CMakeLists.txt
    M compiler-rt/test/asan/Unit/lit.site.cfg.py.in
    M compiler-rt/unittests/lit.common.unit.configured.in

  Log Message:
  -----------
  [test] Fix asan dynamic unit tests with per-target runtime dirs

When LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=on
Asan-i386-calls-Dynamic-Test and Asan-i386-inline-Dynamic-Test fail to
run on a x86_64 host. This is because asan's unit test lit files are
configured once, rather than per target arch as with the non-unit
tests. LD_LIBRARY_PATH ends up incorrect, and the tests try linking
against the x86_64 runtime which fails.

This changes the unit test CMake machinery to configure the default
and dynamic unit tests once per target arch, similar to the other asan
tests. Then the fix from https://reviews.llvm.org/D108859 is adapted
to the unit test Lit files with some modifications.

Fixes PR52158.

Differential Revision: https://reviews.llvm.org/D111756




More information about the All-commits mailing list