[all-commits] [llvm/llvm-project] 3d9272: [mlir][python] Add a warning for cmake version < 3...

Stella Laurenzo via All-commits all-commits at lists.llvm.org
Tue Oct 12 21:14:18 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 3d92722f74993969243d1400bc3257ca3d03902f
      https://github.com/llvm/llvm-project/commit/3d92722f74993969243d1400bc3257ca3d03902f
  Author: Stella Laurenzo <stellaraccident at gmail.com>
  Date:   2021-10-12 (Tue, 12 Oct 2021)

  Changed paths:
    M mlir/CMakeLists.txt
    M mlir/cmake/modules/MLIRDetectPythonEnv.cmake

  Log Message:
  -----------
  [mlir][python] Add a warning for cmake version < 3.15.

As discussed on discord, we have never actually been able to build with the project-wide published min version of 3.14.3. The buildbot that tests the Python configuration is currently pinned to 3.19.1, and there are a number of non-version/policy controlled features that Python building relies on that makes it unreliable with older versions. Some of the issues are pretty fundamental and I don't know how to do them on the older version. I think that, as an optional feature, at least advertising the PSA as in this patch is a good middle ground until the next project-wide CMake version bump.

Also moves setup logic to a macro so that everyone can use it.




More information about the All-commits mailing list