[all-commits] [llvm/llvm-project] dfa8d3: DebugInfo: Update ranges_always.ll to include more...

[David Blaikie via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: dfa8d33eea4122a9864647d8e31acaf0e8acff84
      https://github.com/llvm/llvm-project/commit/dfa8d33eea4122a9864647d8e31acaf0e8acff84
  Author: David Blaikie <dblaikie at gmail.com>
  Date:   2021-10-12 (Tue, 12 Oct 2021)

  Changed paths:
    M llvm/test/DebugInfo/X86/ranges_always.ll

  Log Message:
  -----------
  DebugInfo: Update ranges_always.ll to include more details about how to generate the IR

Also modify the test to be more robust (current IR generation doesn't
include call sites for callees that are only declared but not defined -
so the test case couldn't be regenerated - add a function definition (&
optnone attribute) so it doesn't depend on call sites for
declared-but-not-defined functions)


  Commit: d7e766c781228e5591d4e59068f7566c20a1bf6d
      https://github.com/llvm/llvm-project/commit/d7e766c781228e5591d4e59068f7566c20a1bf6d
  Author: David Blaikie <dblaikie at gmail.com>
  Date:   2021-10-12 (Tue, 12 Oct 2021)

  Changed paths:
    M llvm/test/DebugInfo/X86/ranges_always.ll

  Log Message:
  -----------
  DebugInfo: Add test coverage for non-zero addrx in DW_FORM_LLVM_addrx_offset

Noticed in code review
https://github.com/llvm/llvm-project/commit/4318028cd2d7633a0cdeb0b5d4d2ed81fab87864#commitcomment-57738034

But the issue had already been fixed in
943b3048484b7e3cf04f4d51c23c82fcece2185d due to a code checking tool
(PVS studio) identification, but that lacked test coverage.

Refactor this test a little bit too by using more CHECK-SAME to help the
checks fail sooner (rather than, if the addrx or sizes are wrong, having
that check bind to a much later output line - and then fail due to the
implicit-check-nots, which don't provide a lot of information about
where the intended check was likely to land) & more informatively.


Compare: https://github.com/llvm/llvm-project/compare/f7858e7582e4...d7e766c78122