[all-commits] [llvm/llvm-project] fe2d05: Added OpenMP 5.0 specification based semantic chec...

[NimishMishra via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: fe2d053c4505b7ccc8a86e266e68d2f97aaca1e1
      https://github.com/llvm/llvm-project/commit/fe2d053c4505b7ccc8a86e266e68d2f97aaca1e1
  Author: Nimish Mishra <neelam.nimish at gmail.com>
  Date:   2021-10-12 (Tue, 12 Oct 2021)

  Changed paths:
    M flang/include/flang/Parser/parse-tree.h
    M flang/lib/Parser/openmp-parsers.cpp
    M flang/lib/Parser/unparse.cpp
    M flang/lib/Semantics/check-omp-structure.cpp
    M flang/lib/Semantics/resolve-directives.cpp
    A flang/test/Semantics/omp-sync-critical01.f90
    A flang/test/Semantics/omp-sync-critical02.f90

  Log Message:
  -----------
  Added OpenMP 5.0 specification based semantic checks for CRITICAL construct name resolution

As reported in https://bugs.llvm.org/show_bug.cgi?id=48145, name resolution for omp critical construct was failing. This patch adds functionality to help that name resolution as well as implementation to catch name mismatches.

The following semantic restrictions are therefore handled here:

- If a name is specified on a critical directive, the same name must also be specified on the end critical directive

- If no name appears on the critical directive, no name can appear on the end critical directive

- If a name appears on either the start critical directive or the end critical directive

Reviewed By: kiranchandramohan

Differential Revision: https://reviews.llvm.org/D110502