[all-commits] [llvm/llvm-project] 40546c: Remove 'IgnoreDestructors = true' from cppcoreguid...

[Carlos Galvez via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 40546cb38189e438a81faa6400c103d159600f9e
      https://github.com/llvm/llvm-project/commit/40546cb38189e438a81faa6400c103d159600f9e
  Author: Carlos Galvez <carlosgalvezp at gmail.com>
  Date:   2021-10-12 (Tue, 12 Oct 2021)

  Changed paths:
    M clang-tools-extra/clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp
    M clang-tools-extra/docs/ReleaseNotes.rst
    M clang-tools-extra/test/clang-tidy/checkers/modernize-use-override.cpp

  Log Message:
  -----------
  Remove 'IgnoreDestructors = true' from cppcoreguidelines-explicit-virtual-functions

This requirement was introduced in the C++ Core guidelines in 2016:

https://github.com/isocpp/CppCoreGuidelines/commit/1894380d0abf4d7d49a983005647e0d41ecbf214

Then clang-tidy got updated to comply with the rule.

However in 2019 this decision was reverted:

https://github.com/isocpp/CppCoreGuidelines/commit/5fdfb20b760c5307bf86873798a146fcd7e912e6

Therefore we need to apply the correct configuration to
clang-tidy again.

This also makes this cppcoreguidelines check consistent
with the other 2 alias checks: hicpp-use-override and
modernize-use-override.

Additionally, add another RUN line to the unit test,
to make sure cppcoreguidelines-explicit-virtual-functions
is tested.