[all-commits] [llvm/llvm-project] f11099: [lldb][NFCI] Refactor out attribute parsing from D...

Raphael Isemann via All-commits all-commits at lists.llvm.org
Mon Oct 11 05:41:48 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: f110999bf6b5fe1b5e2b945ea462003655f034d0
      https://github.com/llvm/llvm-project/commit/f110999bf6b5fe1b5e2b945ea462003655f034d0
  Author: Raphael Isemann <teemperor at gmail.com>
  Date:   2021-10-11 (Mon, 11 Oct 2021)

  Changed paths:
    M lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp

  Log Message:
  -----------
  [lldb][NFCI] Refactor out attribute parsing from DWARFASTParserClang::ParseSingleMember

D68422 introduced `ParsedDWARFTypeAttributes` which encapsulated attribute
parsing and storage into its own small struct. This patch is doing the same for
the member type attribute parsing. One utility class is parsing normal member
attributes and the other is parsing the dedicated Objective-C property
attributes.

Right now the patch just makes the `ParseSingleMember` function a bit shorter,
but the bigger benefit is that we can now split up the function into Objective-C
property parsing and parsing of normal members (struct/class members and
Objective-C ivars). The only shared code between those two parsing logic is the
normal member attribute parsing.

Reviewed By: labath

Differential Revision: https://reviews.llvm.org/D111494




More information about the All-commits mailing list