[all-commits] [llvm/llvm-project] cd36ba: Fix bug for Ops with default valued attributes and...

[Tyler Augustine via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: cd36bab4ca901199c753e99cb66143eca52ffed8
      https://github.com/llvm/llvm-project/commit/cd36bab4ca901199c753e99cb66143eca52ffed8
  Author: Tyler Augustine <taugustine at google.com>
  Date:   2021-09-22 (Wed, 22 Sep 2021)

  Changed paths:
    M mlir/test/mlir-tblgen/op-attribute.td
    M mlir/tools/mlir-tblgen/OpDefinitionsGen.cpp

  Log Message:
  -----------
  Fix bug for Ops with default valued attributes and successors/variadic regions.

When both a DefaultValuedAttr and a successor or variadic region was specified, this would generate invalid C++ declaration. There would be the parameter with a default value, followed by the successors/regions, which don't have a default, which is invalid.

Reviewed By: mehdi_amini

Differential Revision: https://reviews.llvm.org/D110205