[all-commits] [llvm/llvm-project] 94a2f9: [GlobalISel] Fix CombinerHelper::isPredecessor for...

[Ahmed Bougacha via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 94a2f9cdb6f9ef9843057030159ee69f76722121
      https://github.com/llvm/llvm-project/commit/94a2f9cdb6f9ef9843057030159ee69f76722121
  Author: Ahmed Bougacha <ahmed at bougacha.org>
  Date:   2021-09-15 (Wed, 15 Sep 2021)

  Changed paths:
    M llvm/lib/CodeGen/GlobalISel/CombinerHelper.cpp

  Log Message:
  -----------
  [GlobalISel] Fix CombinerHelper::isPredecessor for same def/use MI.

The doc comment for isPredecessor says:
  Returns true if \p DefMI precedes \p UseMI or they are the same
  instruction.
And dominates relies on that behavior for its own:
  Returns true if \p DefMI dominates \p UseMI. By definition an
  instruction dominates itself.

Make both statements correct by fixing isPredecessor.
Found by inspection.


  Commit: e159d3cbfc250115d1244f3a6219436a52f90f86
      https://github.com/llvm/llvm-project/commit/e159d3cbfc250115d1244f3a6219436a52f90f86
  Author: Ahmed Bougacha <ahmed at bougacha.org>
  Date:   2021-09-15 (Wed, 15 Sep 2021)

  Changed paths:
    M llvm/lib/Target/AArch64/GISel/AArch64InstructionSelector.cpp
    M llvm/lib/Target/AArch64/GISel/AArch64LegalizerInfo.cpp

  Log Message:
  -----------
  [AArch64][GlobalISel] Use MI::getIntrinsicID in more spots. NFC.

There's technically a difference in the logic used by these
findIntrinsicID and MachineInstr::getIntrinsicID, but it shouldn't
be a meaningful difference here, with G_INTRINSIC instructions.
getIntrinsicID's "first non-def" logic should be correct for those.


Compare: https://github.com/llvm/llvm-project/compare/242524741f35...e159d3cbfc25