[all-commits] [llvm/llvm-project] 6860b1: [MipsISelLowering] avoid emitting libcalls to __mu...

Nick Desaulniers via All-commits all-commits at lists.llvm.org
Thu Sep 2 10:41:54 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 6860b136b9e14e7c5771b710bea7370d5020a94b
      https://github.com/llvm/llvm-project/commit/6860b136b9e14e7c5771b710bea7370d5020a94b
  Author: Nick Desaulniers <ndesaulniers at google.com>
  Date:   2021-09-02 (Thu, 02 Sep 2021)

  Changed paths:
    M llvm/lib/Target/Mips/MipsISelLowering.cpp
    M llvm/test/CodeGen/Mips/llvm-ir/mul.ll
    M llvm/test/CodeGen/Mips/overflow-intrinsic-optimizations.ll
    M llvm/test/CodeGen/Mips/urem-seteq-illegal-types.ll

  Log Message:
  -----------
  [MipsISelLowering] avoid emitting libcalls to __multi3

Similar to D108842 and D108844.

__has_builtin(builtin_mul_overflow) returns true for 32b MIPS targets,
but Clang is deferring to compiler RT when encountering long long types.
This breaks MIPS malta_defconfig builds of the Linux kernel that are
using __builtin_mul_overflow with these types for these targets.

If the semantics of __has_builtin mean "the compiler resolves these,
always" then we shouldn't conditionally emit a libcall.

This will still need to be worked around in the Linux kernel in order to
continue to support malta_defconfig builds of the Linux kernel for this
target with older releases of clang.

Link: https://bugs.llvm.org/show_bug.cgi?id=28629
Link: https://github.com/ClangBuiltLinux/linux/issues/1438

Reviewed By: rengolin

Differential Revision: https://reviews.llvm.org/D108926




More information about the All-commits mailing list