[all-commits] [llvm/llvm-project] 5c9750: [InlineCost] Introduce attributes to override Inli...

[Daniil Suchkov via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 5c97507e2b67ee9194d7eb0a8162ec86ce12afc3
      https://github.com/llvm/llvm-project/commit/5c97507e2b67ee9194d7eb0a8162ec86ce12afc3
  Author: Daniil Suchkov <dsuchkov at azul.com>
  Date:   2021-09-02 (Thu, 02 Sep 2021)

  Changed paths:
    M llvm/lib/Analysis/InlineCost.cpp
    M llvm/test/Transforms/Inline/inline-call-penalty-option.ll
    M llvm/test/Transforms/Inline/inline-cold-callee.ll
    M llvm/test/Transforms/Inline/inline-cold-callsite-pgo.ll
    M llvm/test/Transforms/Inline/inline-cold-callsite.ll
    M llvm/test/Transforms/Inline/inline-cold.ll
    A llvm/test/Transforms/Inline/inline-cost-attributes.ll
    M llvm/test/Transforms/Inline/inline-threshold.ll

  Log Message:
  -----------
  [InlineCost] Introduce attributes to override InlineCost for inliner testing

This patch introduces four new string attributes: function-inline-cost,
function-inline-threshold, call-inline-cost and call-threshold-bonus.
These attributes allow you to selectively override some aspects of
InlineCost analysis. That would allow us to test inliner separately from
the InlineCost analysis.

That could be useful when you're trying to write tests for inliner and
you need to test some very specific situation, like "the inline cost has
to be this high", or "the threshold has to be this low". Right now every
time someone does that, they have get creative to come up with a way to
make the InlineCost give them the number they need (like adding ~30
load/add pairs for a trivial test). This process can be somewhat tedious
which can discourage some people from writing enough tests for their
changes. Also, that results in tests that are fragile and can be easily
broken without anyone noticing it because the test writer can't
explicitly control what input the inliner will get from the inline cost
analysis.

These new attributes will alleviate those problems to an extent.

Reviewed By: mtrofin

Differential Revision: https://reviews.llvm.org/D109033