[all-commits] [llvm/llvm-project] d238b6: [Clang][DiagnosticSemaKinds] combine diagnostic texts

[Nick Desaulniers via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: d238b60285820691b08bcca3ec510d13ea46a5ed
      https://github.com/llvm/llvm-project/commit/d238b60285820691b08bcca3ec510d13ea46a5ed
  Author: Nick Desaulniers <ndesaulniers at google.com>
  Date:   2021-08-06 (Fri, 06 Aug 2021)

  Changed paths:
    M clang/include/clang/Basic/DiagnosticSemaKinds.td
    M clang/lib/Sema/SemaDecl.cpp
    M clang/test/CXX/dcl.dcl/dcl.attr/dcl.attr.noreturn/p1.cpp
    M clang/test/Sema/attr-weak.c
    M clang/test/Sema/internal_linkage.c
    M clang/test/SemaCXX/internal_linkage.cpp

  Log Message:
  -----------
  [Clang][DiagnosticSemaKinds] combine diagnostic texts

The diagnostic texts for warning on attributes that don't appear on the
initial declaration is generally useful.  We'd like to re-use it in
D106030, but first let's combine two that already are very similar so we
may re-use it a third time in that commit.

Also, fix a few places that were using notePreviousDefinition to point
to declarations, to instead use diag::note_previous_declaration.

Reviewed By: aaron.ballman

Differential Revision: https://reviews.llvm.org/D107613