[all-commits] [llvm/llvm-project] bb81e7: [clangd] Add basic support for attributes (selecti...

Sam McCall via All-commits all-commits at lists.llvm.org
Fri Aug 6 13:49:35 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: bb81e7083d25bfc9bcf2bd69f5431d0c53b86a32
      https://github.com/llvm/llvm-project/commit/bb81e7083d25bfc9bcf2bd69f5431d0c53b86a32
  Author: Sam McCall <sam.mccall at gmail.com>
  Date:   2021-08-06 (Fri, 06 Aug 2021)

  Changed paths:
    M clang-tools-extra/clangd/AST.cpp
    M clang-tools-extra/clangd/AST.h
    M clang-tools-extra/clangd/Hover.cpp
    M clang-tools-extra/clangd/Selection.cpp
    M clang-tools-extra/clangd/XRefs.cpp
    M clang-tools-extra/clangd/unittests/ASTTests.cpp
    M clang-tools-extra/clangd/unittests/HoverTests.cpp
    M clang-tools-extra/clangd/unittests/SelectionTests.cpp

  Log Message:
  -----------
  [clangd] Add basic support for attributes (selection, hover)

These aren't terribly common, but we currently mishandle them badly.
Not only do we not recogize the attributes themselves, but we often end up
selecting some node other than the parent (because source ranges aren't accurate
in the presence of attributes).

Differential Revision: https://reviews.llvm.org/D89785




More information about the All-commits mailing list