[all-commits] [llvm/llvm-project] e6620a: Fix test that was never run.

Paul T Robinson via All-commits all-commits at lists.llvm.org
Fri Jul 30 07:59:45 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: e6620a351ecb87a75eca116399c5b359e3c63cc8
      https://github.com/llvm/llvm-project/commit/e6620a351ecb87a75eca116399c5b359e3c63cc8
  Author: Paul Robinson <paul.robinson at sony.com>
  Date:   2021-07-30 (Fri, 30 Jul 2021)

  Changed paths:
    M clang/test/Driver/as-no-warnings.c

  Log Message:
  -----------
  Fix test that was never run.

Commit 83df122 (r368334) added 'REQUIRES: linux' to this test, but
because triples are not respected by REQUIRES, that meant it was
invariably Unsupported.  The correct keyword would be 'system-linux'
(checking the host rather than the target).

Because the test was always skipped, commit 0cfd9e5 (r375439) did not
notice that the test modification was incorrect.

This patch corrects the REQUIRES clause and fixes the incorrect
previous patch.

Found after implementing https://reviews.llvm.org/D107162




More information about the All-commits mailing list