[all-commits] [llvm/llvm-project] b31080: [compiler-rt][CMake][arm64] Use a custom target fo...

Raul Tambre via All-commits all-commits at lists.llvm.org
Mon Jul 26 11:42:42 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: b31080c596246bc26d2493cfd5e07f053cf9541c
      https://github.com/llvm/llvm-project/commit/b31080c596246bc26d2493cfd5e07f053cf9541c
  Author: Raul Tambre <raul at tambre.ee>
  Date:   2021-07-26 (Mon, 26 Jul 2021)

  Changed paths:
    M compiler-rt/cmake/Modules/CompilerRTDarwinUtils.cmake
    M compiler-rt/lib/builtins/CMakeLists.txt

  Log Message:
  -----------
  [compiler-rt][CMake][arm64] Use a custom target for symlinking LSE sources

On Apple platforms the builtins may be built for both arm64 and arm64e.
With Makefile generators separate targets are built using Make sub-invocations.
This causes a race when creating the symlink which may sometimes fail.

Work around this by using a custom target that the builtin targets depend on.
This causes any sub-invocations to depend on the symlinks having been created before.

Mailing list thread: https://lists.llvm.org/pipermail/llvm-dev/2021-July/151822.html

Reviewed By: thakis, steven_wu

Differential Revision: https://reviews.llvm.org/D106305




More information about the All-commits mailing list