[all-commits] [llvm/llvm-project] f59209: [AsmParser] Unify parsing of attributes

[Nikita Popov via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: f59209a86eaf5ec2edea74b9b6e4932148efb3e0
      https://github.com/llvm/llvm-project/commit/f59209a86eaf5ec2edea74b9b6e4932148efb3e0
  Author: Nikita Popov <nikita.ppv at gmail.com>
  Date:   2021-07-15 (Thu, 15 Jul 2021)

  Changed paths:
    M llvm/include/llvm/AsmParser/LLParser.h
    M llvm/lib/AsmParser/LLParser.cpp
    M llvm/test/Assembler/byref-parse-error-10.ll
    M llvm/test/Assembler/byref-parse-error-5.ll
    M llvm/test/Assembler/byref-parse-error-6.ll
    M llvm/test/Assembler/byref-parse-error-7.ll
    M llvm/test/Assembler/byref-parse-error-8.ll
    M llvm/test/Assembler/byref-parse-error-9.ll
    M llvm/test/Assembler/invalid-immarg2.ll
    M llvm/test/Assembler/invalid-immarg3.ll
    M llvm/test/Assembler/invalid-safestack-param.ll
    M llvm/test/Assembler/invalid-safestack-return.ll
    M llvm/test/Assembler/mustprogress-parse-error-0.ll
    M llvm/test/Assembler/mustprogress-parse-error-1.ll
    M llvm/test/Transforms/LoopDeletion/assume.ll
    M llvm/test/Verifier/swifterror2.ll

  Log Message:
  -----------
  [AsmParser] Unify parsing of attributes

Continuing on from D105780, this should be the last major bit of
attribute cleanup. Currently, LLParser implements attribute parsing
for functions, parameters and returns separately, enumerating all
supported (and unsupported) attributes each time. This patch
extracts the common parsing logic, and performs a check afterwards
whether the attribute is valid in the given position. Parameters
and returns are handled together, while function attributes need
slightly different logic to support attribute groups.

Differential Revision: https://reviews.llvm.org/D105938