[all-commits] [llvm/llvm-project] 04bddb: [mlir][crunner] fix bug in memref copy for rank 0

Aart Bik via All-commits all-commits at lists.llvm.org
Thu Jul 15 01:15:29 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 04bddb6cc7c405f1a82ee1d94f96596c2cb387d9
      https://github.com/llvm/llvm-project/commit/04bddb6cc7c405f1a82ee1d94f96596c2cb387d9
  Author: Aart Bik <ajcbik at google.com>
  Date:   2021-07-15 (Thu, 15 Jul 2021)

  Changed paths:
    M mlir/lib/ExecutionEngine/CRunnerUtils.cpp

  Log Message:
  -----------
  [mlir][crunner] fix bug in memref copy for rank 0

While replacing linalg.copy with the more desired memref.copy
I found a bug in the support library for rank 0 memref copying.
The code would loop for something like the following, since there
is code for no-rank and rank > 0, but rank == 0 was unexpected.

  memref.copy %0, %1: memref<f32> to memref<f32>

Note that a "regression test" for this will follow using the
sparse compiler migration to memref.copy which exercises this
case many times.

Reviewed By: herhut

Differential Revision: https://reviews.llvm.org/D106036




More information about the All-commits mailing list