[all-commits] [llvm/llvm-project] 1d9585: [NFC][AMDGPU] autogenerate kill-infinite-loop.ll c...

Ruiling, Song via All-commits all-commits at lists.llvm.org
Wed Jul 14 00:07:07 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 1d9585c8c1ce5c6b9d2e16ba476294b0ee8d9edb
      https://github.com/llvm/llvm-project/commit/1d9585c8c1ce5c6b9d2e16ba476294b0ee8d9edb
  Author: Ruiling Song <ruiling.song at amd.com>
  Date:   2021-07-14 (Wed, 14 Jul 2021)

  Changed paths:
    M llvm/test/CodeGen/AMDGPU/kill-infinite-loop.ll

  Log Message:
  -----------
  [NFC][AMDGPU] autogenerate kill-infinite-loop.ll checks

This would help us to track the assembly changes to these tests.

Reviewed by: foad

Differential Revision: https://reviews.llvm.org/D105609


  Commit: d9b9fdd91bb49292cf7c01bb72ece7e9d9f2e9ac
      https://github.com/llvm/llvm-project/commit/d9b9fdd91bb49292cf7c01bb72ece7e9d9f2e9ac
  Author: Ruiling Song <ruiling.song at amd.com>
  Date:   2021-07-14 (Wed, 14 Jul 2021)

  Changed paths:
    M llvm/lib/Target/AMDGPU/AMDGPUUnifyDivergentExitNodes.cpp
    M llvm/test/CodeGen/AMDGPU/kill-infinite-loop.ll
    M llvm/test/CodeGen/AMDGPU/multi-divergent-exit-region.ll
    M llvm/test/CodeGen/AMDGPU/update-phi.ll

  Log Message:
  -----------
  [AMDGPU] Don't handle export done when unify exit nodes

This patch aims to revert the changes introduced by D70781 D71192 D76364

D70781 was introduced to fix hardware hang where we do not insert exp-
null-done for a kill inside infinit loop. At that time we have not added
exp-null-done for kill early termination, but I believe as for now, we will
always add the exp-null-done for early termination case in LaterBranchLowering.

D71192 was introduced to handle the only_kill case, which is also been
handled by the kill early termination work.

D76364 was used to fix a regression by D71192, where we cleared the done
bit of the export in the existing program and not let the normal return
block branching to the new unified return block.

With this change, we just trust frontends have setup exp-done correctly
which is true for all existing frontends. The backend only inserts
exp-null-done for the kill cases which is handled in SILateBranchLowering.cpp.

Reviewed by: critson

Differential Revision: https://reviews.llvm.org/D105610


Compare: https://github.com/llvm/llvm-project/compare/40e3df2a1b22...d9b9fdd91bb4


More information about the All-commits mailing list