[all-commits] [llvm/llvm-project] 1d8030: [NFC] Do not track calls to inlined intrinsics in ...

dobbelaj-snps via All-commits all-commits at lists.llvm.org
Tue Jul 13 01:36:27 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 1d8030053d46b89e3677986d059065c6a2e7a2e1
      https://github.com/llvm/llvm-project/commit/1d8030053d46b89e3677986d059065c6a2e7a2e1
  Author: Jeroen Dobbelaere <jeroen.dobbelaere at synopsys.com>
  Date:   2021-07-13 (Tue, 13 Jul 2021)

  Changed paths:
    M llvm/lib/Transforms/IPO/Inliner.cpp
    M llvm/lib/Transforms/Utils/InlineFunction.cpp

  Log Message:
  -----------
  [NFC] Do not track calls to inlined intrinsics in IFI.

Just like intrinsics are not tracked for IFI.InlinedCalls, they should not be tracked for IFI.InlinedCallSites.

In the current top-of-tree this change is a NFC, but the full restrict patches (D68484) potentially trigger an read-after-free
if intrinsics are also added to the InlindeCallSites, due to a late optimization potentially removing some of the inlined intrinsics.

Also see https://lists.llvm.org/pipermail/llvm-dev/2021-July/151722.html for a discussion about the problem.

Reviewed By: aeubanks

Differential Revision: https://reviews.llvm.org/D105805




More information about the All-commits mailing list