[all-commits] [llvm/llvm-project] 379f24: Revert "Revert "Reset the wakeup timeout when we r...

[jimingham via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 379f24ffde03d1730f1e8332574865277a5478fe
      https://github.com/llvm/llvm-project/commit/379f24ffde03d1730f1e8332574865277a5478fe
  Author: Jim Ingham <jingham at apple.com>
  Date:   2021-07-12 (Mon, 12 Jul 2021)

  Changed paths:
    M lldb/include/lldb/Target/Process.h
    M lldb/source/Plugins/Platform/gdb-server/PlatformRemoteGDBServer.cpp
    M lldb/source/Plugins/Process/gdb-remote/GDBRemoteClientBase.cpp
    M lldb/source/Plugins/Process/gdb-remote/GDBRemoteClientBase.h
    M lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp
    M lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.h
    M lldb/source/Plugins/Process/gdb-remote/GDBRemoteRegisterContext.cpp
    M lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
    M lldb/source/Target/Process.cpp
    M lldb/source/Target/TargetProperties.td
    R lldb/test/API/functionalities/gdb_remote_client/TestHaltFails.py
    A lldb/test/API/functionalities/step-vrs-interrupt/Makefile
    A lldb/test/API/functionalities/step-vrs-interrupt/TestStepVrsInterruptTimeout.py
    A lldb/test/API/functionalities/step-vrs-interrupt/main.cpp
    M lldb/unittests/Process/gdb-remote/GDBRemoteClientBaseTest.cpp
    M lldb/unittests/Process/gdb-remote/GDBRemoteCommunicationClientTest.cpp
    M lldb/unittests/tools/lldb-server/tests/TestClient.cpp

  Log Message:
  -----------
  Revert "Revert "Reset the wakeup timeout when we re-enter the continue wait.""

This reverts commit 82a38837150099288a1262391ef43e1fd69ffde4.

The original version had a copy-paste error: using the Interrupt timeout
for the ResumeSynchronous wait, which is clearly wrong.  This error would
have been evident with real use, but the interrupt is long enough that it
only caused one testsuite failure (in the Swift fork).

Anyway, I found that mistake and fixed it and checked all the other places
where I had to plumb through a timeout, and added a test with a short
interrupt timeout stepping over a function that takes 3x the interrupt timeout
to complete, so that should detect a similar mistake in the future.