[all-commits] [llvm/llvm-project] 408433: [mlir][sparse] Add Merger unit tests (with gcc5 bu...

Gus Smith via All-commits all-commits at lists.llvm.org
Mon Jul 12 13:36:25 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 40843347b37cc73fd0208c63a19359df6b2bf67b
      https://github.com/llvm/llvm-project/commit/40843347b37cc73fd0208c63a19359df6b2bf67b
  Author: Gus Smith <gusss at google.com>
  Date:   2021-07-12 (Mon, 12 Jul 2021)

  Changed paths:
    M mlir/unittests/Dialect/CMakeLists.txt
    A mlir/unittests/Dialect/SparseTensor/CMakeLists.txt
    A mlir/unittests/Dialect/SparseTensor/MergerTest.cpp

  Log Message:
  -----------
  [mlir][sparse] Add Merger unit tests (with gcc5 build fix)

This is a fix of https://reviews.llvm.org/D104956, which broke the gcc5 build.

We opt to use unit tests rather than check tests as the lattice/merger code is a small C++ component with a well-defined API. Testing this API via check tests would be far less direct and readable. In addition, as the check tests will only be able to test the API indirectly, the tests may break based on unrelated changes; e.g. changes in linalg.

Reviewed By: aartbik

Differential Revision: https://reviews.llvm.org/D105828




More information about the All-commits mailing list