[all-commits] [llvm/llvm-project] 6ac328: [Attributes] Replace doesAttrKindHaveArgument() (NFC)

Nikita Popov via All-commits all-commits at lists.llvm.org
Mon Jul 12 12:57:51 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 6ac32872ee2fa02bdce54b25641d9a21cfbcfa9a
      https://github.com/llvm/llvm-project/commit/6ac32872ee2fa02bdce54b25641d9a21cfbcfa9a
  Author: Nikita Popov <nikita.ppv at gmail.com>
  Date:   2021-07-12 (Mon, 12 Jul 2021)

  Changed paths:
    M llvm/include/llvm/IR/Attributes.h
    M llvm/lib/Analysis/AssumeBundleQueries.cpp
    M llvm/lib/IR/AttributeImpl.h
    M llvm/lib/IR/Attributes.cpp
    M llvm/lib/IR/Verifier.cpp
    M llvm/lib/Transforms/Utils/AssumeBundleBuilder.cpp
    M mlir/lib/Target/LLVMIR/ModuleTranslation.cpp

  Log Message:
  -----------
  [Attributes] Replace doesAttrKindHaveArgument() (NFC)

This is now the same as isIntAttrKind(), so use that instead, as
it does not require manual maintenance. The naming is also more
accurate in that both int and type attributes have an argument,
but this method was only targeting int attributes.

I initially wanted to tighten the AttrBuilder assertion, but we
have some in-tree uses that would violate it.




More information about the All-commits mailing list