[all-commits] [llvm/llvm-project] 3fb062: [Attributes] Assert correct attribute constructor ...

Nikita Popov via All-commits all-commits at lists.llvm.org
Mon Jul 12 12:12:24 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 3fb0621fafbb16ea157830b308c26a77ba0a04e3
      https://github.com/llvm/llvm-project/commit/3fb0621fafbb16ea157830b308c26a77ba0a04e3
  Author: Nikita Popov <nikita.ppv at gmail.com>
  Date:   2021-07-12 (Mon, 12 Jul 2021)

  Changed paths:
    M llvm/include/llvm/IR/Attributes.h
    M llvm/lib/Bitcode/Reader/BitcodeReader.cpp
    M llvm/lib/IR/Attributes.cpp

  Log Message:
  -----------
  [Attributes] Assert correct attribute constructor is used (NFCI)

Assert that enum/int/type attributes go through the constructor
they are supposed to use.

To make sure this can't happen via invalid bitcode, explicitly
verify that the attribute kind if correct there.


  Commit: 363e12ae6fceea3870898bc230841c8b0b00925a
      https://github.com/llvm/llvm-project/commit/363e12ae6fceea3870898bc230841c8b0b00925a
  Author: Nikita Popov <nikita.ppv at gmail.com>
  Date:   2021-07-12 (Mon, 12 Jul 2021)

  Changed paths:
    M llvm/lib/IR/Attributes.cpp

  Log Message:
  -----------
  [Attributes] Simplify attribute sorting (NFCI)

It's not necessary to explicitly sort by enum/int/type attribute,
as the attribute kinds are already sorted this way. We can directly
sort by kind.


Compare: https://github.com/llvm/llvm-project/compare/b4a6fa12d1fd...363e12ae6fce


More information about the All-commits mailing list