[all-commits] [llvm/llvm-project] e49985: Remove unused parameter from parseMSInlineAsm.
Simon Tatham via All-commits
all-commits at lists.llvm.org
Mon Jul 12 07:07:26 PDT 2021
Branch: refs/heads/main
Home: https://github.com/llvm/llvm-project
Commit: e49985bb6065d4f5ea69fe578e326ec6d43a6b24
https://github.com/llvm/llvm-project/commit/e49985bb6065d4f5ea69fe578e326ec6d43a6b24
Author: Simon Tatham <simon.tatham at arm.com>
Date: 2021-07-12 (Mon, 12 Jul 2021)
Changed paths:
M clang/lib/Parse/ParseStmtAsm.cpp
M llvm/include/llvm/MC/MCParser/MCAsmParser.h
M llvm/lib/MC/MCParser/AsmParser.cpp
M llvm/lib/MC/MCParser/MasmParser.cpp
Log Message:
-----------
Remove unused parameter from parseMSInlineAsm.
No implementation uses the `LocCookie` parameter at all. Errors are
reported from inside that function by `llvm::SourceMgr`, and the
instance of that at the clang call site arranges to pass the error
messages back to a `ClangAsmParserCallback`, which is where the clang
SourceLocation for the error is computed.
(This is part of a patch series working towards the ability to make
SourceLocation into a 64-bit type to handle larger translation units.
But this particular change seems beneficial in its own right.)
Reviewed By: miyuki
Differential Revision: https://reviews.llvm.org/D105490
More information about the All-commits
mailing list